Skip to content

bun: Add auto-updater script#192265

Merged
AndersonTorres merged 2 commits intoNixOS:masterfrom
Milo123459:milo/auto-update-bun
Sep 23, 2022
Merged

bun: Add auto-updater script#192265
AndersonTorres merged 2 commits intoNixOS:masterfrom
Milo123459:milo/auto-update-bun

Conversation

@Milo123459
Copy link
Contributor

@Milo123459 Milo123459 commented Sep 21, 2022 •
edited
Loading

Description of changes

Adds an auto-updater to the Bun package. Fixes #191784

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

nixos-discourse commented Sep 21, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/add-auto-update-script-to-bun/21793/4

@Milo123459 Milo123459 changed the title Add auto-updter to Bun Add auto-updater to Bun Sep 21, 2022
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
@jtojnar
Copy link
Member

jtojnar commented Sep 21, 2022

Also the commit message should start with the package name followed by colon as per the contributing guidelines.

jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
@Milo123459 Milo123459 changed the title Add auto-updater to Bun bun: Add auto-updater script Sep 21, 2022
@Milo123459
Copy link
Contributor Author

Milo123459 commented Sep 21, 2022

Quick question, what is the equivalent of "cut"? It doesn't seem to be a package. FWIW, I'm trying to remove the first 5 letters from a string.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 21, 2022
@jtojnar
Copy link
Member

jtojnar commented Sep 21, 2022

It is part of the coreutils package. Or you can just do it in jq with https://stedolan.github.io/jq/manual/#Array/StringSlice:.[10:15]

jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
jtojnar
jtojnar reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, did not test, would be nice to squash the commits.

@Milo123459
Copy link
Contributor Author

Milo123459 commented Sep 21, 2022

Thank you for all the help!

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Sep 21, 2022
@ofborg ofborg bot requested review from 06kellyjac and DAlperin September 21, 2022 16:59
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 21, 2022
@ofborg ofborg bot removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 21, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 21, 2022
DAlperin
DAlperin approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@DAlperin DAlperin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but reading through it makes sense.

@bobby285271 bobby285271 added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Sep 21, 2022
AndersonTorres
AndersonTorres suggested changes Sep 22, 2022
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@Milo123459 @AndersonTorres
Update pkgs/development/web/bun/default.nix
0a08b8a 
Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
@ofborg ofborg bot requested a review from DAlperin September 22, 2022 06:26
@bobby285271 bobby285271 removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Sep 22, 2022
@AndersonTorres AndersonTorres merged commit 8664317 into NixOS:master Sep 23, 2022
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
@cdmistman cdmistman mentioned this pull request Jul 22, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

@06kellyjac 06kellyjac Awaiting requested review from 06kellyjac

@DAlperin DAlperin Awaiting requested review from DAlperin

+1 more reviewer

@AndersonTorres AndersonTorres AndersonTorres requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add bun auto-update script

7 participants

@Milo123459 @nixos-discourse @jtojnar @AndersonTorres @DAlperin @bobby285271 @Janik-Haag